Track tree depth to avoid stack overflow #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
force-pushed
the
sanketk/24-07/dos-bug
branch
from
766640c to
855835b
Compare
|
merged #697 -- can you rebase this? |
sanket1729
force-pushed
the
sanketk/24-07/dos-bug
branch
from
855835b to
dfabe2d
Compare
|
Looks like the new test is failing. |
sanket1729
force-pushed
the
sanketk/24-07/dos-bug
branch
from
dfabe2d to
14f0d7c
Compare
|
@apoelstra, the new test was not testing the correct thing :) . This is now fixed. 🤞 CI passes this time. |
|
@apoelstra ready for review. |
apoelstra
approved these changes
Jul 9, 2024
|
Needs backport. |
|
Opened #705 to release new 12.x version. |
apoelstra
added a commit
that referenced
this pull request
Jul 14, 2024
fd823e8 release 11.1.0 (Andrew Poelstra) 0d28ebc Add offending test case (Sanket Kanjalkar) 351b192 Track miniscript tree depth explicitly (Sanket Kanjalkar) Pull request description: ACKs for top commit: apoelstra: ACK fd823e8 Tree-SHA512: 643309ed7b0f3c32b52c9fba59b6973c3a3f017b2f5f083c6623205e40f641c707a4aab469f00d48975df100604bc109aa1005abe8ec1d9e4d132b9b0e38c46b
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ck overflow
14f0d7cb96180f616edbd8a531bc9beaeb4dac0f Apply cargo fmt (Sanket Kanjalkar)
49a3cf19fcf21142c53ffa5c97191c2359f047ef Add offending test case (Sanket Kanjalkar)
362671291594e76c1824317741076b94f87f5272 Track miniscript tree depth explicitly (Sanket Kanjalkar)
Pull request description:
We track tree depth at the time of parsing, but that is insufficient because wrappers also count towards the stack limit when creating `Miniscript` structure.
We could also fix this by fixing the wrappers to be limited to size 10 or something(wrappers are only for transformation of types, they don't provide any additional functionality).
Long term we want to move towards to complete non-recursive parsing, this is a good stop gap solution to address the current issues.
ACKs for top commit:
apoelstra:
ACK 14f0d7cb96180f616edbd8a531bc9beaeb4dac0f
Tree-SHA512: 157ff56de164dd8ef96df4e3f3b379fe1c7663c969bec8825ea6ae3faed70ab4b14d7ad6b9e0cea4e97b86cb5fa159837317505bec8c03231dff5d1e545aa9b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We track tree depth at the time of parsing, but that is insufficient because wrappers also count towards the stack limit when creating
Miniscriptstructure.We could also fix this by fixing the wrappers to be limited to size 10 or something(wrappers are only for transformation of types, they don't provide any additional functionality).
Long term we want to move towards to complete non-recursive parsing, this is a good stop gap solution to address the current issues.