plan: make LoggerAssetProvider constructible #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like we have an example AssetProvider that is intended to be used for testing/debugging. It looks useful but evidently has never been used because it was impossible to construct. Recent versions of rust nightly notice this and output a warning about this, which is causing CI to fail, so we need to fix it. My solution is to make the inner `Assets` public (and also a reference, since there is no need to take ownership) so that people can easily construct and deconstruct the type.
tcharding
approved these changes
Jun 17, 2024
|
cc @sanket1729 |
|
@apoelstra, need to merge this before #704 . |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…r constructible
c79639d8ef016fe2d7291d1a826fdea8d47c91a2 clippy: fix doc indentation (Andrew Poelstra)
b39b70772788596caee7acbc4ca1ec5277892f1e plan: make LoggerAssetProvider constructible (Andrew Poelstra)
Pull request description:
It looks like we have an example AssetProvider that is intended to be used for testing/debugging. It looks useful but evidently has never been used because it was impossible to construct.
Recent versions of rust nightly notice this and output a warning about this, which is causing CI to fail, so we need to fix it.
My solution is to make the inner `Assets` public (and also a reference, since there is no need to take ownership) so that people can easily construct and deconstruct the type.
ACKs for top commit:
tcharding:
ACK c79639d8ef016fe2d7291d1a826fdea8d47c91a2
sanket1729:
ACK c79639d8ef016fe2d7291d1a826fdea8d47c91a2
Tree-SHA512: c19e00c88f79edd7b99632470b556385a36ba59112d8015222321581f87d0110f155fc725bfc05187201fc7a3845998427887852d09bda0e20354570de4b7e8e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we have an example AssetProvider that is intended to be used for testing/debugging. It looks useful but evidently has never been used because it was impossible to construct.
Recent versions of rust nightly notice this and output a warning about this, which is causing CI to fail, so we need to fix it.
My solution is to make the inner
Assetspublic (and also a reference, since there is no need to take ownership) so that people can easily construct and deconstruct the type.