Use hash_newtype macro instead of the hash256 module #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
01-10-hash256
branch
2 times, most recently
from
a62cb6c to
a2b08e6
Compare
Member
We currently implement the `hash256::Hash` type manually however there is a macro in `bitcoin::hashes` that can do that for us. For context, the `hash256::Hash` type exists solely to enable the type to display forwards since `hashes::sha256d` displays backwards. The `hash_newtype` macro takes an argument to configure display.
tcharding
force-pushed
the
01-10-hash256
branch
from
a2b08e6 to
0b482cd
Compare
Member
Author
|
Done! No other changes. |
apoelstra
approved these changes
Jan 14, 2023
sanket1729
approved these changes
Jan 14, 2023
| use bitcoin::hashes::{hash_newtype, sha256d}; | ||
|
|
||
| #[rustfmt::skip] | ||
| hash_newtype!(Hash, sha256d::Hash, 32, doc = "A bitcoin block hash.", false); |
Member
There was a problem hiding this comment.
Merging this now to fix the CI. But we should update the doc-comment to reflect that this is just double-hashed sha256::Hash with display forward and not a bitcoin block hash.
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…d of the hash256 module
0b482cd755e3d7c693fffe54849f31204269d45a Use hash_newtype macro instead of the hash256 module (Tobin C. Harding)
4eaf2611e464e0169c36b9a926fac6fed5d6edf5 Fix CI (sanket1729)
Pull request description:
We currently implement the `hash256::Hash` type manually however there is a macro in `bitcoin::hashes` that can do that for us.
For context, the `hash256::Hash` type exists solely to enable the type to display forwards since `hashes::sha256d` displays backwards. The `hash_newtype` macro takes an argument to configure display.
ACKs for top commit:
apoelstra:
ACK 0b482cd755e3d7c693fffe54849f31204269d45a
sanket1729:
ACK 0b482cd755e3d7c693fffe54849f31204269d45a
Tree-SHA512: 4f5cb44c3fc65b986375565b1c613e99784bfbc5da30542283e39552f986d07ab1876636857d207d9c5d9497719dfcd28ecc1125671f78f171fb041aa770f148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently implement the
hash256::Hashtype manually however there is a macro inbitcoin::hashesthat can do that for us.For context, the
hash256::Hashtype exists solely to enable the type to display forwards sincehashes::sha256ddisplays backwards. Thehash_newtypemacro takes an argument to configure display.