Clarify that alloy tests don't actually test timelock mixing #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
force-pushed
the
timelock_mix_issue_514
branch
from
673eadf to
e94efbf
Compare
Member
Author
|
MSRV is also breaking, so added a CI fix to this PR. |
tcharding
approved these changes
Jan 9, 2023
Member
Author
|
@apoelstra, can you take a look at this quick PR? Should fix the CI here. |
Member
|
Looks good. Running tests now, assuming it succeeds you should see an ACK within the hour. |
apoelstra
approved these changes
Jan 15, 2023
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…t actually test timelock mixing
e94efbfa3d270eb3a4d6cf19a94998e1f8053cad Clarify that alloy tests don't actually test timelock mixing (sanket1729)
62219d482ca05f3a969d18bb15445e084d0102d1 Fix CI (sanket1729)
Pull request description:
ACKs for top commit:
tcharding:
ACK e94efbfa3d270eb3a4d6cf19a94998e1f8053cad
apoelstra:
ACK e94efbfa3d270eb3a4d6cf19a94998e1f8053cad
Tree-SHA512: 0e166887d75b7e2b688254a876c8ae9fb8233225aaacd6c963222b95cfa187abcee15ef84921ba684dd054c88bea3c19c1671735fb6102b5d8fe11b4df471f1e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.