ci: use with-connect action for Posit Connect integration tests
#351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
force-pushed
the
with-connect-ci
branch
from
f0e3f9a to
d29699b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses https://github.com/posit-dev/with-connect to modernize the Posit Connect test suite and get running again. See a passing CI run here: https://github.com/rstudio/pins-python/actions/runs/19110527979/job/54606158812?pr=351#step:5:192
Other changes include:
CONNECT_SERVERandCONNECT_API_KEYenv vars for those values by default, for consistency with other Connect API clients and the Connect documentation_HackyConnecttoLoginConnectApibecause all it does is allow you to log in with username and password instead of API key.test_board_pin_search_admin_user, is skipped: for some reason this didn't work with the new setup. However, I think it is really just testing how Connect does authorization, not howpinsworks, so I'm not sure it is necessary.There's more cleanup I'd like to do here, but maybe I'll follow up with something else, just to keep this PR more focused.
Fix #341