-
Notifications
You must be signed in to change notification settings - Fork 12
Description
There seems to have been changes in the Connect API for login/adding users that have broken our testing setup*. We test pins on Connect (locally and in CI) by building Connect in a docker container, adding an admin and some users, and then run the pins tests against Connect. With the upstream API changes, we can't create our fake users, leaving us in a constant loop of:
make: *** [Makefile:14: dev-start] Error 56
pins.rsconnect.api.RsConnectApiRequestError: {'code': 30, 'error': "We couldn't log you in with the provided credentials. Please ask your administrator for assistance.", 'payload': None}
I investigated the R package connectapi for clues, and it appears we're doing about the same thing (potential suspect? vs Python). I tried updating to an exact port of the create_first_admin from the connectapi package, but am still seeing the same error.
Part of the problem is that pins has its own HackyConnect and Connect API implementation, which is difficult to maintain as it requires decent levels of Connect context to keep up to date. When there are updates to how we need to handle Connect, we tend to see them in confusing breakages like this.
Since the R pins package uses the well-maintained R connectapi package, there is no impact on the R side. This doesn't break Python pins functionality since pins itself does not handle user creation directly. However, all our tests will fail until it is resolved.
*or at least this is my best guess from the errors and investigation