Upgrade to Bootstrap v5.3.1 #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oise in build output
…s in the shiny preset
… now a CSS var, so I'm just changing well-bg back to what it used to default to)
cpsievert
force-pushed
the
bootstrap-v5.3.1
branch
from
360c46a to
e28ab0f
Compare
…now defaults to a CSS variable
…in the usual way)
gadenbuie
approved these changes
Aug 22, 2023
Member
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
I read through the changes and this all looks good to me! I'm okay taking this now and addressing fixes in smaller PRs, if any arise.
Similarly, I don't think we should set preset = "shiny" yet since I'm sure we'll have to make some adjustments there after this (or at least it might save us some work if we're lucky).
Co-authored-by: Garrick Aden-Buie <[email protected]>
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #743
For reference, here are the Bootstrap changes twbs/bootstrap@v5.2.2...v5.3.1
Notable "breaking" changes
tools/patches/033-accordion-defaults.patch(which made opinionated styling decisions about accordions in a "global" way) toinst/builtin/bs5/shiny/, effectively meaning that accordions will go back to the usual Bootstrap styling by default (at least until we makebs_theme(preset="shiny")the default)TODO
027-navbar-active-color-bs5-legacy?bs_theme_preview()works