perf(rrweb): attribute mutation optimization #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 354fbee The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mdellanoce
changed the title
Member
|
This looks great @mdellanoce! If you could add a changeset (see #1343 (comment)) I'll merge it for you |
YunFeng0817
approved these changes
Nov 3, 2023
mdellanoce
force-pushed
the
md-process-mutation-attributes-lookup
branch
from
ee885e9 to
354fbee
Compare
Contributor
Author
|
@Juice10 @YunFeng0817 added a changeset |
This was referenced Dec 4, 2023
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Apr 19, 2024
Ref: rrweb-io#1343 Co-authored-by: Michael Dellanoce <[email protected]>
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Jul 31, 2024
lewgordon-amplitude
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large lists of attribute modifications can bog down on the
attributes.findinprocessMutation. Added a benchmark to demonstrate.Before:
After:
