Skip to content

upstream: perf(rrweb): attribute mutation optimization #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2024
Merged

upstream: perf(rrweb): attribute mutation optimization #178

merged 1 commit into from
Apr 19, 2024

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Apr 19, 2024 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Apr 19, 2024

size-limit report 📦

Path Size
rrweb - record only (gzipped) 16.81 KB (+0.06% 🔺)
rrweb - record & CanvasManager only (gzipped) 19.62 KB (+0.04% 🔺)
rrweb - record only (min) 57.32 KB (+0.14% 🔺)
rrweb - record with treeshaking flags (gzipped) 15.6 KB (+0.04% 🔺)

@billyvg billyvg changed the title perf(rrweb): attribute mutation optimization (#1343) upstream: perf(rrweb): attribute mutation optimization Apr 19, 2024
@billyvg billyvg marked this pull request as ready for review April 19, 2024 14:11
@billyvg billyvg requested a review from a team April 19, 2024 14:11
@billyvg billyvg merged commit 02e711d into sentry-v2 Apr 19, 2024
@billyvg billyvg deleted the upstream-05478c36dde03a118099783d908bb3e465e9859c branch April 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@c298lee c298lee c298lee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@billyvg @c298lee @mdellanoce