fix: Rrror parser throw #1225
Merged
fix: Rrror parser throw #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Jul 6, 2023
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Jul 27, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 3, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
eoghanmurray
pushed a commit
to eoghanmurray/rrweb
that referenced
this pull request
Aug 8, 2023
* Warn instead of throwing error when parsing for console logs * Added error to warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error parser can throw if it fails to parse the error which is very meta. This ends up being logged / caught in Sentry which is unnecessary.
Changes
Rather than wrapping all of the places it is used, simply changes the function to return cleanly with a warning