Skip to content

fix: Rrror parser throw #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2023
Merged

fix: Rrror parser throw #1225

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f43e99
Warn instead of throwing error when parsing for console logs
benjackwhite May 15, 2023
08e3217
Added error to warning
benjackwhite May 15, 2023
046acf4
Apply formatting changes
benjackwhite May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/rrweb/src/plugins/console/record/error-stack-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ export const ErrorStackParser = {
} else if (error.stack) {
return this.parseFFOrSafari(error as { stack: string });
} else {
throw new Error('Cannot parse given Error object');
console.warn(
'[console-record-plugin]: Failed to parse error object:',
error,
);
return [];
}
},
// Separate line and column numbers from a string of the form: (URI:Line:Column)
Expand Down