Skip to content

[Feature Request]: Ensure to use unpatched `requestAnimationFrame #1384

@mydea

Description

@mydea

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

We noticed that when using rrweb with Angular (which uses Zone.js under the hood), you'd often run into major performance problems. A user has probably tracked down the issue, which is that angular patches requestAnimationFrame for change detection, and since rrweb uses that quite a lot this may lead to performance issues.

Proposed Solution

I implemented a tentative fix for this here: getsentry#150
Which is to pull requestAnimationFrame from an iframe to get a "fresh" instance. Would you be interested to also have this in the mainline rrweb? If so, I'd happily port this over here as well.

Alternatives Considered

Leave it as is, it's not technically a bug.

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions