fix(rrweb): Use unpatched requestAnimationFrame when possible
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained here: getsentry/sentry-javascript#6946 (comment) the usage of `requestAnimationFrame` can lead to issues when working with Zone.js.
3 tasks
size-limit report 📦
|
Lms24
approved these changes
Jan 4, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I like this solution! Thinking about it, we might run into some kind of trouble for no longer using a patched version of raf but let's worry about it if anyone complains 😅
Curious how much this is gonna improve perf on Angular!
1 task
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 5, 2024
- fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150) - ref: Avoid async in canvas (#143) - feat: Bundle canvas worker manually (#144) - build: Build for ES2020 (#142)
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 8, 2024
- fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150) - ref: Avoid async in canvas (#143) - feat: Bundle canvas worker manually (#144) - build: Build for ES2020 (#142)
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 10, 2024
This bump contains the following changes: - fix(rrweb): Use unpatched requestAnimationFrame when possible [#150](getsentry/rrweb#150) - ref: Avoid async in canvas [#143](getsentry/rrweb#143) - feat: Bundle canvas worker manually [#144](getsentry/rrweb#144) - build: Build for ES2020 [#142](getsentry/rrweb#142) Extracted out from #9826 Closes #6946
billyvg
pushed a commit
that referenced
this pull request
Apr 26, 2024
As explained here: getsentry/sentry-javascript#6946 (comment) the usage of `requestAnimationFrame` can lead to issues when working with Zone.js. With this fix, where possible we should now use the `requestAnimationFrame` implementation from an iframe, if possible, and else fall back on just using `window.requestAnimationFrame` as before. We already do something similar in sentry-javascript to get an unpatched `fetch`: https://github.com/getsentry/sentry-javascript/blob/23ef22b115c8868861896cc9003bd4bb6afb0690/packages/browser/src/transports/utils.ts#L65-L71 so this should hopefully work fine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained here: getsentry/sentry-javascript#6946 (comment) the usage of
requestAnimationFramecan lead to issues when working with Zone.js.With this fix, where possible we should now use the
requestAnimationFrameimplementation from an iframe, if possible, and else fall back on just usingwindow.requestAnimationFrameas before.We already do something similar in sentry-javascript to get an unpatched
fetch: https://github.com/getsentry/sentry-javascript/blob/23ef22b115c8868861896cc9003bd4bb6afb0690/packages/browser/src/transports/utils.ts#L65-L71 so this should hopefully work fine!