[Travis CI] Run ROS Kinetic test on a docker image on Travis. #225

130s · 2016-05-26T22:37:15Z

May replace #224

I'm not sure if this suits the need in this repo, but industrial_ci has been used by dozens of ROS repositories and recently we added Kinetic support. Since Xenial runs on docker image we don't need to wait until Travis CI supports 16.04.

bmagyar · 2016-05-26T22:58:02Z

Cool, thanks!
What do you guys think, @efernandez @davetcoleman ?

efernandez · 2016-05-30T16:39:26Z

.travis.yml

  - gcc
 notifications:
  email:
+    on_success: always


This should use change instead of always, as it was before

efernandez · 2016-05-30T16:46:41Z

I've re-run the jobs. It seems they're working fine, but just one test failed.

BTW, is this running only kinetic, or also indigo and jade everytime? I see up to 7 (sub)jobs.

I've commented which configuration thing is different. Curiously, I haven't received any email. Let's see after this run.

efernandez · 2016-05-30T17:23:16Z

The tests failed again. They're some tests that depend somehow on the timing, but the solution for now has been to run the tests sequentially, not in parallel.

I think they are running in parallel because these is passed to the run_tests target: -p4 --make-args -j8.
Could you change the configuration to use -j1 (and -p1 if needed) instead, please?

130s · 2016-05-31T21:57:49Z

I think they are running in parallel because these is passed to the run_tests target: -p4 --make-args -j8.
Could you change the configuration to use -j1 (and -p1 if needed) instead, please?

I think I added those options. Now only Prerelease Test jobs (Indigo, Jade) passed.

Others seem to be failing at [diff_drive_controller.rosunit-diff_drive_limits_test/testAngularJerkLimits] (eg). Any idea?

efernandez · 2016-05-31T22:09:58Z

That test seems to be highly dependant on timing. I have unittest for that and I should probably replace the rostest with them, but I haven't sent any PR yet because I'd like to know why the rostest fails.

Anyway, this PR now LGTM. I've just re-run the job to see if now everything passes.

BTW, is there a way to only run the kinetic job? I mean, when a PR goes into ros-controls kinetic-devel it should only test kinetic, not all the previous releases. Indeed, those are already tested with Travis CI w/o Docker.

130s · 2016-05-31T22:43:22Z

BTW, is there a way to only run the kinetic job? I mean, when a PR goes into ros-controls kinetic-devel it should only test kinetic, not all the previous releases. Indeed, those are already tested with Travis CI w/o Docker.

Yes, I've now removed jobs for earlier ROS distros.

I just want to be clear though; I thought running non-required jobs (i.e. allow_failure) for the branches that are not the main target ({ indigo/jade }-devel in this case) is nice for conveniently checking the validity of the PR.

But those jobs are already failing. I haven't gone into detail but with a random look at an indigo build:

[joint_trajectory_controller:make] /home/travis/ros/ws_ros_controllers/src/ros_controllers/joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller_impl.h:447:22: error: ‘class realtime_tools::RealtimeServerGoalHandle<control_msgs::FollowJointTrajectoryAction_<std::allocator > >’ has no member named ‘preallocated_feedback_’

There might have been API change so different distros don't build against each other? If so running jobs for indigo and jade no longer makes sense indeed.

efernandez · 2016-05-31T22:47:29Z

Yes, kinetic-devel breaks the API wrt to previous, or probably in jade-devel. Thanks for removing them.

mathias-luedtke · 2016-06-01T06:04:10Z

.travis.yml

-  - cd ~/ros/ws_ros_controls/src
-  - wstool init .
-  # Download non-debian stuff
-  - wstool merge https://raw.github.com/ros-controls/ros_control/$ROS_DISTRO-devel/ros_control.rosinstall


The source overlay is not included in the new config.

Nice catch. I have to get ros-industrial/industrial_ci#47 move forward before I can enable source overlay.

mathias-luedtke · 2016-06-01T06:16:49Z

That test seems to be highly dependant on timing. I have unittest for that and I should probably replace the rostest with them, but I haven't sent any PR yet because I'd like to know why the rostest fails.

If the *.test are run in parallel they communicate via the same topics..
I guess it would help to add a top-level group with a unique namespace to each *.test.
(I believe rostest uses dedicated ROS masters..)

davetcoleman · 2016-06-03T17:33:08Z

.travis.yml

+    on_success: change
+    on_failure: change
    recipients:
      - [email protected]


I don't need to be on these emails if anyone else wants to watch them...

davetcoleman · 2016-06-03T17:35:00Z

+1 to switching to the ros-industrial CI, not clear to me why checks are failing though

[Travis CI] Parallel config. [Travis CI] Run jobs for only Kinetic. [Travis CI] Add a job for workspace overlay. Utilize common variables instead of defining them for each job.

130s · 2016-06-06T01:55:02Z

I think comments are addressed. Waiting for the Travis jobs to finish.

efernandez · 2016-06-15T23:43:01Z

For me it seems this can be merged. There's a rostest from diff_drive_controller failing, which has known issues: essentially the results are affected by the time it takes to run the test.

bmagyar · 2016-06-16T09:17:01Z

LGTM 👍 Merging...

130s force-pushed the kinetic/travis_docker branch from 724ee2d to ae65a0d Compare May 26, 2016 22:41

130s mentioned this pull request May 26, 2016

Update .travis.yml for Kinetic #224

Closed

130s force-pushed the kinetic/travis_docker branch from ae65a0d to 94f080d Compare May 27, 2016 18:41

efernandez reviewed May 30, 2016
View reviewed changes

mathias-luedtke reviewed Jun 1, 2016
View reviewed changes

130s force-pushed the kinetic/travis_docker branch from 1ca90b5 to cc5de33 Compare June 1, 2016 23:25

davetcoleman reviewed Jun 3, 2016
View reviewed changes

130s force-pushed the kinetic/travis_docker branch from cc5de33 to 6b94b67 Compare June 6, 2016 01:52

[Travis CI] Run ROS Kinetic test on a docker image on Travis.

df02474

[Travis CI] Parallel config. [Travis CI] Run jobs for only Kinetic. [Travis CI] Add a job for workspace overlay. Utilize common variables instead of defining them for each job.

130s force-pushed the kinetic/travis_docker branch from 6b94b67 to df02474 Compare June 6, 2016 01:54

k-okada mentioned this pull request Jun 7, 2016

re-enable travs within docker container ros-perception/vision_opencv#136

Merged

bmagyar merged commit 6817ab4 into ros-controls:kinetic-devel Jun 16, 2016

130s deleted the kinetic/travis_docker branch June 16, 2016 17:04

jihoonl mentioned this pull request Jun 28, 2017

Configure travis to use docker image for testing. RobotWebTools/rosbridge_suite#282

Closed

[Travis CI] Run ROS Kinetic test on a docker image on Travis. #225

[Travis CI] Run ROS Kinetic test on a docker image on Travis. #225

Uh oh!

Conversation

130s commented May 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmagyar commented May 26, 2016

Uh oh!

efernandez May 30, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

efernandez commented May 30, 2016

Uh oh!

efernandez commented May 30, 2016

Uh oh!

130s commented May 31, 2016

Uh oh!

efernandez commented May 31, 2016

Uh oh!

130s commented May 31, 2016

Uh oh!

efernandez commented May 31, 2016

Uh oh!

mathias-luedtke Jun 1, 2016

Choose a reason for hiding this comment

Uh oh!

130s Jun 1, 2016

Choose a reason for hiding this comment

Uh oh!

mathias-luedtke commented Jun 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davetcoleman Jun 3, 2016

Choose a reason for hiding this comment

Uh oh!

davetcoleman commented Jun 3, 2016

Uh oh!

130s commented Jun 6, 2016

Uh oh!

efernandez commented Jun 15, 2016

Uh oh!

bmagyar commented Jun 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

130s commented May 26, 2016 •

edited

Loading

efernandez May 30, 2016 •

edited

Loading

mathias-luedtke commented Jun 1, 2016 •

edited

Loading