Skip to content

Conversation

@efernandez
Copy link
Contributor

This fixes the Travis configuration:

  • Now it builds the code with kinetic, not hydro
  • Now it runs the tests

#223 should be re-run after this gets merged.

@efernandez
Copy link
Contributor Author

FYI @bmagyar

This is an updated cherry-pick of #211

If this passes, I'll then update all the .travis.yml for the other repos on ros-controls

@efernandez
Copy link
Contributor Author

This is failing here:

$ sudo apt-get install -qq -y python-dev python-catkin-pkg python-rosdep python-wstool ros-$ROS_DISTRO-catkin ros-$ROS_DISTRO-ros python-rosinstall python-catkin-tools python-catkin-pkg python-rospkg python-vcstools
E: Unable to locate package ros-kinetic-catkin
E: Unable to locate package ros-kinetic-ros

@bmagyar Is that because those two are NOT ready for kinetic yet?

Maybe the $(lsb_release -cs) I used it's NOT well converted into xenial?

Full raw log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/133222368/log.txt

@bmagyar
Copy link
Member

bmagyar commented May 26, 2016

I would expect catkin_tools to pull in the right version of catkin so I think the install instruction for that could be omitted.

BTW I highly doubt that those 2 are missing... Went looking around and I don't see any trouble around them.

- "2.7"
# Author: Dave Coleman, Enrique Fernandez
sudo: required
dist: xenial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure if Ubuntu 16.04 is already available on Travis CI?

From one of the logs, it seems the job is running on 12.04 to me:

Build dist: xenial
�[34m�[1mBuild image provisioning date and time�[0m
Tue Dec 15 16:36:18 UTC 2015
�[34m�[1mOperating System Details�[0m
Distributor ID: Ubuntu
Description:    Ubuntu 12.04.5 LTS
Release:    12.04
Codename:   precise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the note! Probably we are not getting (I definitely don't!) how Travis works haha.
I've found this:
https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

Perhaps we need to change the scripts to use docker on Travis and get a 1604 environment that way? If that's possible at all...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a replacement option #225

@efernandez
Copy link
Contributor Author

I clearly misunderstood this travis-ci/travis-ci#5821

@130s Thanks for your contribution, but I have a few questions and no time now to investigate them. Maybe you can answer some of them:

  1. In your PR, you use the industrial_ci repo. How are the recipes there to install ros-controls repos?
  2. The .travis.yml of your PR looks like a copy from industrial_ci because the emails and other general configuration are completely different from the ones we use here. Could you update them?
  3. The Travis jobs is also failing on your PR. I'll have to look why?
  4. If we decide to depend on industrial_ci, are there any additional dependencies or repos tested other than ros-controls ones?
  5. If we need to do some changes to the Docker recipes, how would we do that?

@130s
Copy link
Contributor

130s commented May 27, 2016

Since some of your questions are good ones and common enough, I added my answers to FAQ page. See a rendered version here.

1 In your PR, you use the industrial_ci repo. How are the recipes there to install ros-controls repos?
3 The Travis jobs is also failing on your PR. I'll have to look why?

Hopefully the README above helps.

2 The .travis.yml of your PR looks like a copy from industrial_ci because the emails and other general configuration are completely different from the ones we use here. Could you update them?

Oops! Email recipients are updated.
But config-wise I don't see any ros-control specific in https://github.com/ros-controls/ros_controllers/pull/224/files.

5 If we need to do some changes to the Docker recipes, how would we do that?

Thanks for the feedback! Added a request.

4 If we decide to depend on industrial_ci, are there any additional dependencies or repos tested other than ros-controls ones?

Sorry I don't get what you mean.

@efernandez
Copy link
Contributor Author

@130s Thanks for your replies. Regarding question 4, I mean: does industrial_ci has some dependencies that could brake the system and probably they're not needed at all for running the ros-controls repos?

But generally, using industrial_ci looks a good idea to me, as it already provides a good configuration to run kinetic inside Travis CI Docker containers. Thanks for pointing it out! 😃

I've updated the comments on #225

@130s
Copy link
Contributor

130s commented May 31, 2016

Regarding question 4, I mean: does industrial_ci has some dependencies that could brake the system and probably they're not needed at all for running the ros-controls repos?

I must say there are a lot of dependency; Travis CI server itself, ROS binary repository, github, all apt repos that the depended packages are fetched from. For example this ticketed issue is caused by apt server side that industrial_ci has no influence on.
(And exception handling currently implemented is far from being perfect...)

@efernandez
Copy link
Contributor Author

Since #225 was merged and this PR didn't add Travis support to Travis properly because it needs a Docker container for Ubuntu xenial, I'm going to close it in favour of the other.

@efernandez efernandez closed this Aug 3, 2016
@efernandez efernandez deleted the update_travis_for_kinetic branch August 3, 2016 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants