Skip to content

[pid] Add documentation to fields #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

[pid] Add documentation to fields #173

merged 1 commit into from
Mar 10, 2025

Conversation

@christophfroehlich
Copy link
Contributor

  1. p_error and d_error are duplicates, see here
  2. p_term, i_term, d_term is actually misleading, because they are the gains.

can we change it? (will break packages using it)
or shall we deprecate it and add new ones?

@christophfroehlich christophfroehlich mentioned this pull request Mar 7, 2025
Merged
bmagyar
bmagyar approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes to removing but we should branch for Jazzy.
I think prior to that, this PR would improve things on the current branches.

@christophfroehlich christophfroehlich merged commit 9f15e1a into master Mar 10, 2025
10 checks passed
@christophfroehlich christophfroehlich deleted the doc/pid_msg branch March 10, 2025 19:16
@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Mar 10, 2025 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@christophfroehlich @mergify
Add documentation to fields (#173)
75fcfa4 
(cherry picked from commit 9f15e1a)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
christophfroehlich pushed a commit that referenced this pull request Mar 10, 2025
@mergify
Add documentation to fields (#173) (#174)
7a0f006
@christophfroehlich christophfroehlich mentioned this pull request Mar 12, 2025
Merged
@mergify mergify bot mentioned this pull request Jun 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar approved these changes

@saikishor saikishor saikishor approved these changes

@livanov93 livanov93 Awaiting requested review from livanov93

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

@mcbed mcbed Awaiting requested review from mcbed

@moriarty moriarty Awaiting requested review from moriarty

@qiayuanl qiayuanl Awaiting requested review from qiayuanl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christophfroehlich @bmagyar @saikishor