Call e2e workflow on test #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
reviewed
Jun 2, 2023
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
I've got a quick question regarding the dependency among the two jobs.
jackkleeman
force-pushed
the
e2e-workflow-call
branch
2 times, most recently
from
9459934 to
3286fe8
Compare
jackkleeman
force-pushed
the
e2e-workflow-call
branch
from
3286fe8 to
d93a6f6
Compare
tillrohrmann
reviewed
Jun 2, 2023
jackkleeman
force-pushed
the
e2e-workflow-call
branch
4 times, most recently
from
baa5274 to
27679de
Compare
jackkleeman
force-pushed
the
e2e-workflow-call
branch
from
27679de to
498240d
Compare
tillrohrmann
approved these changes
Jun 8, 2023
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
LGTM. +1 for merging once the required PR for the e2e tests has been merged.
jackkleeman
force-pushed
the
e2e-workflow-call
branch
from
e031e67 to
756cb60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72