enable completions for handwritten JSX components #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
approved these changes
Feb 1, 2023
| @@ -559,6 +559,19 @@ let getJsxLabels ~componentPath ~findTypeOfValue ~package = | |||
| && Path.last path = "props" -> | |||
| (* JSX V4 external or interface *) | |||
| getFieldsV4 ~path ~typeArgs | |||
| | Tarrow (Nolabel, typ, _, _) -> ( | |||
| (* Component without the JSX PPX, like a make fn taking a hand-written | |||
There was a problem hiding this comment.
Should one check anything about the return type? Or can it be anything?
There was a problem hiding this comment.
We could check the return type for sure but I'm unsure if it really matters that much. Strictly though it needs to be React.element, or whatever JSX element is configured (not sure if it can be configured now, but it'll be possible later). For this to error, you'd need to use a JSX component with a make function in a module that takes a type named props, and return something else then React.element (which will error in compilation anyway).
I say we go without it for this case, and then fix it if need be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707
A bit unsure if this is the best approach. What do you think @cristianoc ?