JSX v4 auto completion

[dkirchhof]

Hello,

I replaced the language server of my rescript-vim plugin to the latest one from this vs code plugin.
Unfortunatelly I have problems with the auto completion for props of a custom component.

In your "screenshot" (https://forum.rescript-lang.org/t/call-for-testing-more-autocomplete/4078#completion-for-jsx-prop-values-2) everything looks fine.

In my editor it doesn't work:

In normal html tags the auto completion works as expected:

Setup:
editor: neovim
rescript version: 10.1.0
server version: 1.10.0
jsx version: 4
jsx mode: automatic

[zth]

I guess this is because you're not using the @react.component annotation. What happens when you try using?

We should probably support this pattern too now with JSX v4.

[dkirchhof]

You're right. With @react.component and labeled arguments the auto completion shows all props (text and key).

[zth]

Thanks. We'll look into supporting this case as well.

[zth]

To be clear - this isn't actually about JSX v4, just that this pattern is now more expected than before. @react.component is still the recommended way with JSX v4, so this is about supporting this "alternate" pattern.

[dkirchhof]

Oh, didn't know that it was possible before. Thanks for clarification.