fix: Remove conditional attributes after the condition is unmatched #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrina-p
commented
Nov 4, 2023
sandrina-p
commented
Nov 6, 2023
sandrina-p
commented
Nov 6, 2023
sandrina-p
commented
Nov 6, 2023
brennj
reviewed
Nov 6, 2023
brennj
reviewed
Nov 6, 2023
brennj
reviewed
Nov 6, 2023
Collaborator
brennj
left a comment
brennj
left a comment
There was a problem hiding this comment.
Just one small thing needs to be changed and its only a lint error. Otherwise, tests are fantastic and I'm so happy we have this now.
sandrina-p
force-pushed
the
rmt-58-jsf-conditionals-keywords-are-redundant-eg-readonly-false
branch
from
2427ac9 to
9fb57cf
Compare
dilvane
reviewed
Nov 6, 2023
Collaborator
dilvane
left a comment
dilvane
left a comment
There was a problem hiding this comment.
This is a fantastic fix! Thanks for this, until now, we were using the "workaround" to override the attribute like you showed in the playground, but with the "const" the need for this fix is more visible!
brennj
approved these changes
Nov 7, 2023
sandrina-p
deleted the
rmt-58-jsf-conditionals-keywords-are-redundant-eg-readonly-false
branch
Collaborator
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #56
How? When the fields get updated after parsing each conditional, compare the conditional attrs to the previous base field attrs. If an attr in the prev base is no longer present in the conditional, then remove it.