Draft: [Experiment] Try to clear old attributes on conditionals #52
Conversation
|
|
||
| const updateValues = (fieldValues) => | ||
| const updateValues = (fieldValues) => { | ||
| ['const', 'default', 'minimum', 'maximum', 'minLength', 'maxLength'].forEach((key) => { |
There was a problem hiding this comment.
todo: I don't need to be explicit about the downsides of having a hardcoded list of keys right? So the best we can do for now is to extract this to a function/variable and add a little but important comment about it.
p.s. It's missing readOnly, description, and statement, which are very common too.
There was a problem hiding this comment.
exactly, this was thrown together, will improve! ... i think it causes other problems for descriptions, need to investigate exactly what happens
| if (key === 'value') { | ||
| // The value of the field should not be driven by the json-schema, | ||
| // unless it's a read-only field | ||
| // unless it's a read-only field or a forced value |
There was a problem hiding this comment.
q: why do we need this line change?
| expect(handleValidation({ ten_only: null }).formErrors).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('Should clear the default from number when removed from condition', () => { |
There was a problem hiding this comment.
todo: Can you check the tests for schemaWithConditionalReadOnlyProperty? Now we should be able to remove the redundant conditional readOnly:false (because it's the default state) and still pass.
|
Closing in favour of #57 |
TODO: fill this in and explain why its a problem