fix(next): don't override options property provided via x-jsf-presentation
#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng options property
lukad
force-pushed
the
options-from-x-jsf-presentation
branch
from
4872810 to
adfb96c
Compare
lukad
requested review from
antoniocapelo,
dragidavid,
eng-almeida and
sandrina-p
lukad
changed the title
x-jsf-presentation
lukad
changed the title
x-jsf-presentationoptions property provided via x-jsf-presentation
antoniocapelo
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with schemas where options are provided via
x-jsf-presentationand the schema usesenumoritems.enuminstead ofoneOfwithconst&title.Previously we were always trying to generate options from the
enumeven if options were already provided viax-jsf-presentationand thus also spread onto the field. In those cases we must not try to generateoptionbased on theenum.I've added a test that shows an example schema for which we were generating incorrect options previously.