fix(next): take x-jsf-presentation options into account when generating options property

Author: lukad

next/src/field/schema.ts

@@ -332,15 +332,19 @@ export function buildFieldSchema(
     })
   }
 
-  // Handle options
-  const options = getFieldOptions(schema)
-  if (options) {
-    field.options = options
-    if (schema.type === 'array') {
-      field.multiple = true
+  // Generate options from schema if no options were provided via x-jsf-presentation
+  if (field.options === undefined) {
+    const options = getFieldOptions(schema)
+    if (options) {
+      field.options = options
+      if (schema.type === 'array') {
+        field.multiple = true
+      }
     }
   }
-  else {
+
+  // Options and fields are mutually exclusive, so we only add fields if no options were provided
+  if (field.options === undefined) {
     // We did not find options, so we might have an array to generate fields from
     const fields = getFields(schema, strictInputType)
     if (fields) {

next/test/fields.test.ts

@@ -235,6 +235,45 @@ describe('fields', () => {
     ])
   })
 
+  it('creates options from an enum inside items (deprecated)', () => {
+    const schema: JsfSchema = {
+      type: 'object',
+      properties: {
+        currency: {
+          'type': 'array',
+          'items': {
+            type: 'string',
+            enum: ['usd', 'eur', 'gbp'],
+          },
+          'x-jsf-presentation': {
+            options: [
+              {
+                label: 'USD',
+                value: 'usd',
+              },
+              {
+                label: 'EUR',
+                value: 'eur',
+              },
+              {
+                label: 'GBP',
+                value: 'gbp',
+              },
+            ],
+          },
+        },
+      },
+    }
+
+    const fields = buildFieldSchema(schema, 'root', true)!.fields!
+
+    expect(fields[0].options).toEqual([
+      { label: 'USD', value: 'usd' },
+      { label: 'EUR', value: 'eur' },
+      { label: 'GBP', value: 'gbp' },
+    ])
+  })
+
   describe('radio field', () => {
     it('builds a radio field with options', () => {
       const schema: JsfSchema = {