Avoid unnecessary router subscribes #10409
Conversation
🦋 Changeset detectedLatest commit: 7eeb1da The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }); | ||
| }, [router, state]); | ||
| let [state, setState] = React.useState(router.state); | ||
| React.useLayoutEffect(() => router.subscribe(setState), [router, setState]); |
There was a problem hiding this comment.
No need to check for identity since router.subscribe won't fire unless it changes (and React will bail out if it's the same anyway - https://reacttraining.com/blog/state-in-react-is-immutable)
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
4 participants
Rebased #10400 onto the
release-nextbranch for inclusion in 6.11 since this fixes an issue in Remix apps on React 17.