Skip to content

Conversation

@alexandernanberg
Copy link
Contributor

Avoids unsubscribing/subscribing every time state changes

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

⚠️ No Changeset found

Latest commit: f71ba51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 26, 2023

Hi @alexandernanberg,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Apr 26, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 changed the base branch from dev to brophdawg11/router-layout-effect April 27, 2023 19:39
@brophdawg11
Copy link
Contributor

Thanks @alexandernanberg! This actually fixes a react 17 issue we found separately when integrating this into Remix 1.16 so I'm going to merge this to a branch of mine so I can rebase it into the 6.11 release branch.

@brophdawg11 brophdawg11 merged this pull request into remix-run:brophdawg11/router-layout-effect Apr 27, 2023
@alexandernanberg alexandernanberg deleted the avoid-unnecessary-router-resubscribe branch October 25, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants