Distributed: support mget and mapped_mget #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tubbo
reviewed
Jun 23, 2017
lib/redis/distributed.rb
Outdated
| def mapped_mget(*keys) | ||
| raise CannotDistribute, :mapped_mget | ||
| results = {} | ||
| keys.group_by { |k| node_for k }.each do |node, subkeys| |
There was a problem hiding this comment.
this could also be each_with_object({}) do |results, (node, subkeys)|.
Map the keys to their nodes, mget them on each node, and stitch the results together.
|
redis-store is waiting to merge redis-store/redis-store#282 until this one gets into redis.rb. |
djanowski
added a commit
that referenced
this pull request
Aug 25, 2017
|
Should be out soon in the form of ~4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming a patch we use to support distributed cache lookups. Map the keys to their nodes, mget them on each node, and stitch the results together.
Apparently this component is frozen and unmaintained. That's a shame, considering caching is a common use case for Redis, and will become more so with upcoming support for LFU expiry. Sharing for posterity, in any case.
Related: #673, #554, #478, #12.