DistRedis#mget Quesion/Issue

[levicook]

I don't think DistRedis#mget maps to Redis#mgets correctly.

I created a gist to highlight the issue. http://gist.github.com/268284

Do you think DistRedis should map mgets this way?

[levicook]

Related points.

Do callers expect mget to return values in the same order the keys where in (with nils on misses)? My hack doesn't really worry about this, but it probably should....

(Update: the gist's mget response is congruent with the input keys now)

Do you think DistRedis#pipelined should be grouping commands by node too?

[ezmobius]

Yeah this is the hard part about using a hashing scheme to distribute requests. I think we can do a mget across nodes fairly easily but for pipelines I think we may need to disable them on DistRedis because otherwise we would have to pull apart the pipeline to try to regroup it based on the key, this way lies madness of a full blown redis parser or some other hackery.

But we should figure out or document how these things should work with DistRedis.

[djanowski]

In current master, Redis::Distributed#pipelined is disabled: http://github.com/ezmobius/redis-rb/blob/master/lib/redis/distributed.rb#L420

[djanowski]

We added support for more methods on Redis::Distributed as long as you're using key tags (so that we can ensure that the keys involved are in the same node). Would love to know what you guys think.