Skip to content

RI-7186 validate job name separately #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ArtemHoruzhenko
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko commented Aug 5, 2025

Omit job validation schema from jobs schema and process it separately. This will fix behavior when name became mandatory in the root of jobs yaml.
Handle job name validation the same way as job body on UI
Screenshot 2025-08-06 at 09 44 42

KIvanow
KIvanow previously approved these changes Aug 5, 2025
@ArtemHoruzhenko ArtemHoruzhenko force-pushed the fe/feature/RI-7186-jobs-validation-fix branch from 15ccce0 to 41759a7 Compare August 5, 2025 18:48
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.46% 18983/23303
🟡 Branches 66.82% 8291/12408
🟡 Functions 75.24% 4966/6600
🟢 Lines 81.87% 18582/22696

Test suite run success

4867 tests passing in 635 suites.

Report generated by 🧪jest coverage report action from 2ac3f9f

@ArtemHoruzhenko ArtemHoruzhenko marked this pull request as ready for review August 6, 2025 06:46
KrumTy
KrumTy previously approved these changes Aug 6, 2025
Base automatically changed from fe/feature/RI-7217-allow-deplot-invalid-rdi-pipeline to fe/feature/RI-7039-replace-eui August 7, 2025 08:37
@ArtemHoruzhenko ArtemHoruzhenko dismissed stale reviews from KrumTy and KIvanow August 7, 2025 08:37

The base branch was changed.

@ArtemHoruzhenko ArtemHoruzhenko force-pushed the fe/feature/RI-7186-jobs-validation-fix branch from 2ac3f9f to b2c2a62 Compare August 7, 2025 08:41
@ArtemHoruzhenko ArtemHoruzhenko merged commit 2e5d9ee into fe/feature/RI-7039-replace-eui Aug 7, 2025
1 check passed
@ArtemHoruzhenko ArtemHoruzhenko deleted the fe/feature/RI-7186-jobs-validation-fix branch August 7, 2025 08:46
ArtemHoruzhenko added a commit that referenced this pull request Aug 7, 2025
* RI-7186 validate job name separately

* RI-7186 add tests

(cherry picked from commit 2e5d9ee)
ArtemHoruzhenko added a commit that referenced this pull request Aug 7, 2025
* RI-7217 allow to deplot rdi pipeline with validation errors (#4796)

* RI-7217 allow to deplot rdi pipeline with validation errors

* align text and icon

* RI-7217 move errors list to a separate component and add tests

* RI-7217 fix PR comments

* RI-7217 fix test

---------

Co-authored-by: pd-redis <[email protected]>
(cherry picked from commit a3a28b5)

* RI-7186 validate job name separately (#4804)

* RI-7186 validate job name separately

* RI-7186 add tests

(cherry picked from commit 2e5d9ee)

---------

Co-authored-by: pd-redis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants