RI-7217 allow to deplot rdi pipeline with validation errors #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage - Frontend unit tests
Test suite run success4846 tests passing in 635 suites. Report generated by 🧪jest coverage report action from c9ed88c |
ArtemHoruzhenko
requested review from
KrumTy,
pawelangelow,
dantovska,
pd-redis and
KIvanow
as code owners
valkirilov
previously approved these changes
Aug 6, 2025
KrumTy
reviewed
Aug 6, 2025
Comment on lines
14
to
18
| <Text> | ||
| <ul> | ||
| {validationErrors.map((err, index) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <li key={index}>{err}</li> |
There was a problem hiding this comment.
not sure if should be used as top level wrapper of ul
There was a problem hiding this comment.
it is pointless to wrap ul in p, it just
pd-redis
reviewed
Aug 6, 2025
Comment on lines
10
to
22
|
|
||
| return ( | ||
| <> | ||
| {validationErrors?.length && ( | ||
| <Text> | ||
| <ul> | ||
| {validationErrors.map((err, index) => ( | ||
| // eslint-disable-next-line react/no-array-index-key | ||
| <li key={index}>{err}</li> | ||
| ))} | ||
| </ul> | ||
| </Text> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| return ( | |
| <> | |
| {validationErrors?.length && ( | |
| <Text> | |
| <ul> | |
| {validationErrors.map((err, index) => ( | |
| // eslint-disable-next-line react/no-array-index-key | |
| <li key={index}>{err}</li> | |
| ))} | |
| </ul> | |
| </Text> | |
| )} | |
| if(!validationErrors?.length) { | |
| return null | |
| } | |
| return ( | |
| <ul> | |
| {validationErrors.map((err, index) => ( | |
| // eslint-disable-next-line react/no-array-index-key | |
| <li key={index}>{err}</li> | |
| ))} | |
| </ul> | |
| ) |
KrumTy
approved these changes
Aug 7, 2025
KIvanow
approved these changes
Aug 7, 2025
pd-redis
approved these changes
Aug 7, 2025
ArtemHoruzhenko
merged commit a3a28b5
into
fe/feature/RI-7039-replace-eui
20 checks passed
ArtemHoruzhenko
deleted the
fe/feature/RI-7217-allow-deplot-invalid-rdi-pipeline
branch
ArtemHoruzhenko
added a commit
that referenced
this pull request
Aug 7, 2025
* RI-7217 allow to deplot rdi pipeline with validation errors * align text and icon * RI-7217 move errors list to a separate component and add tests * RI-7217 fix PR comments * RI-7217 fix test --------- Co-authored-by: pd-redis <[email protected]> (cherry picked from commit a3a28b5)
ArtemHoruzhenko
added a commit
that referenced
this pull request
Aug 7, 2025
* RI-7217 allow to deplot rdi pipeline with validation errors (#4796) * RI-7217 allow to deplot rdi pipeline with validation errors * align text and icon * RI-7217 move errors list to a separate component and add tests * RI-7217 fix PR comments * RI-7217 fix test --------- Co-authored-by: pd-redis <[email protected]> (cherry picked from commit a3a28b5) * RI-7186 validate job name separately (#4804) * RI-7186 validate job name separately * RI-7186 add tests (cherry picked from commit 2e5d9ee) --------- Co-authored-by: pd-redis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show validation errors in a tooltips and do not block deploy button in case of validation errors
