Skip to content

Fix bug with ready event #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Fix bug with ready event #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95aae03
Fix bug with ready event
agjohnson Feb 19, 2025
ce10359
Release 0.31.0
agjohnson Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bumpver.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpver]
current_version = "0.30.0"
current_version = "0.31.0"
version_pattern = "MAJOR.MINOR.PATCH[TAG]"
commit_message = "Release {new_version}"
tag_message = "{new_version}"
Expand Down
16 changes: 8 additions & 8 deletions dist/readthedocs-addons.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/readthedocs-addons.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@readthedocs/addons",
"version": "0.30.0",
"version": "0.31.0",
"description": "Read the Docs Addons to embed into documentation pages",
"main": "dist/readthedocs-addons.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion src/readthedocs-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export function getReadTheDocsConfig(sendUrlParam) {
return response.json();
})
.then((data) => {
return dispatchEvent(
dispatchEvent(
EVENT_READTHEDOCS_ADDONS_INTERNAL_DATA_READY,
document,
new ReadTheDocsEventData(data),
Expand Down
2 changes: 1 addition & 1 deletion src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { EVENT_READTHEDOCS_URL_CHANGED } from "./events";
export const ADDONS_API_VERSION = "1";
export const ADDONS_API_ENDPOINT = "/_/addons/";
// This is managed by bumpver automatically
export const CLIENT_VERSION = "0.30.0";
export const CLIENT_VERSION = "0.31.0";

// WEBPACK_ variables come from Webpack's DefinePlugin and Web Test Runner's RollupReplace plugin
export const IS_TESTING =
Expand Down