Fix bug with ready event #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `return` here is incorrect and this is causing the function to be exiting too early.
humitos
approved these changes
Feb 19, 2025
Member
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
Works fine. It would be good if you can write a test case for this.
Contributor
Author
|
I was surprised there were no tests to catch this bug. I won't have much time to dive deeper here though and don't want to hold this up from merging. I'll add an issue though |
simonbowly
added a commit
to Gurobi/gurobi-sphinxtheme
that referenced
this pull request
Feb 19, 2025
This reverts commit a414fff. Issue fixed with readthedocs/addons#544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
returnhere is incorrect and this is causing the function to beexiting too early.