Skip to content

Set default visibility to hidden and export the public API #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Set default visibility to hidden and export the public API #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b821af9
Set default visibility to hidden and export the public API
saghul Nov 25, 2023
fa7a5c0
fixup!
saghul Nov 26, 2023
7902a6f
feedback!
saghul Nov 26, 2023
a18d6aa
clean!
saghul Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ include(GNUInstallDirs)
# TODO:
# - Support cross-compilation

set(CMAKE_C_VISIBILITY_PRESET hidden)
set(CMAKE_C_STANDARD_REQUIRED ON)
set(CMAKE_C_EXTENSIONS ON)
set(CMAKE_C_STANDARD 11)
Expand Down Expand Up @@ -47,8 +48,6 @@ if(CMAKE_BUILD_TYPE MATCHES "Debug")
add_compile_options(-O0)
xcheck_add_c_compiler_flag(-ggdb)
xcheck_add_c_compiler_flag(-fno-omit-frame-pointer)
else()
xcheck_add_c_compiler_flag(-g)
endif()

macro(xoption OPTION_NAME OPTION_TEXT OPTION_DEFAULT)
Expand Down Expand Up @@ -257,6 +256,7 @@ if(BUILD_EXAMPLES AND NOT MINGW)
add_library(fib MODULE examples/fib.c)
set_target_properties(fib PROPERTIES
PREFIX ""
C_VISIBILITY_PRESET default
)
target_compile_definitions(fib PRIVATE JS_SHARED_LIBRARY)
if(APPLE)
Expand All @@ -266,6 +266,7 @@ if(BUILD_EXAMPLES AND NOT MINGW)
add_library(point MODULE examples/point.c)
set_target_properties(point PROPERTIES
PREFIX ""
C_VISIBILITY_PRESET default
)
target_compile_definitions(point PRIVATE JS_SHARED_LIBRARY)
if(APPLE)
Expand All @@ -275,6 +276,7 @@ if(BUILD_EXAMPLES AND NOT MINGW)
add_library(bjson MODULE tests/bjson.c)
set_target_properties(bjson PROPERTIES
PREFIX ""
C_VISIBILITY_PRESET default
)
target_compile_definitions(bjson PRIVATE JS_SHARED_LIBRARY)
if(APPLE)
Expand Down
4 changes: 4 additions & 0 deletions cutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@

#include "cutils.h"

#pragma GCC visibility push(default)

void pstrcpy(char *buf, int buf_size, const char *str)
{
int c;
Expand Down Expand Up @@ -603,3 +605,5 @@ void rqsort(void *base, size_t nmemb, size_t size, cmp_f cmp, void *opaque)
}
}
}

#pragma GCC visibility pop
Loading