Skip to content

Set default visibility to hidden and export the public API #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 26, 2023
Merged

Set default visibility to hidden and export the public API #140

merged 4 commits into from
Nov 26, 2023

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Nov 25, 2023

No description provided.

@saghul saghul requested a review from bnoordhuis November 25, 2023 23:56
@saghul
Copy link
Contributor Author

saghul commented Nov 25, 2023

@bnoordhuis WDYT? The use of many inlines in the header file make it required to export "internal" simbols...

bnoordhuis
bnoordhuis approved these changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be nice if all function parameters got lined up again. :-)

@saghul
Copy link
Contributor Author

saghul commented Nov 26, 2023

LGTM but it would be nice if all function parameters got lined up again. :-)

Sure thing, I wouldn't be able to sleep at night otherwise :-P Just wanted some feedback on the weird stuff like the pragma to be able to use cutils stuff...

Looks like I'll need to figure out why extension module loading broke 😅 That's for tomorrow night!

@bnoordhuis
Copy link
Contributor

The use of many inlines in the header file make it required to export "internal" simbols...

You could add a JS_EXTERN_PRIVATE define that's just like JS_EXTERN except to indicate it's not for public use.

(Maybe not the greatest name because private_extern linkage is a thing but oh well.)

@saghul
Copy link
Contributor Author

saghul commented Nov 26, 2023

I think I figured it out, check the fixup commit.

@saghul
Copy link
Contributor Author

saghul commented Nov 26, 2023

Ah lol, I did not see your commits! 😅

@saghul saghul marked this pull request as ready for review November 26, 2023 00:19
@saghul saghul merged commit fb1b1ce into master Nov 26, 2023
@saghul saghul deleted the symbol-visibility branch November 26, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saghul @bnoordhuis