Skip to content

add ParseSrc function so the source of the datadict doesn't have to be a filepath. #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2021
Merged

add ParseSrc function so the source of the datadict doesn't have to be a filepath. #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions datadictionary/datadictionary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package datadictionary

import (
"encoding/xml"
"io"
"os"
)

Expand Down Expand Up @@ -305,15 +306,20 @@ func Parse(path string) (*DataDictionary, error) {
}
defer xmlFile.Close()

return ParseSrc(xmlFile)
}

//ParseSrc loads and and build a datadictionary instance from an xml source.
func ParseSrc(xmlSrc io.Reader) (*DataDictionary, error) {
doc := new(XMLDoc)
decoder := xml.NewDecoder(xmlFile)
decoder := xml.NewDecoder(xmlSrc)
if err := decoder.Decode(doc); err != nil {
return nil, err
}

b := new(builder)
var dict *DataDictionary
if dict, err = b.build(doc); err != nil {
dict, err := b.build(doc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this change, the declaration of dict above is no longer necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ye, I thought it was there for stylistic reasons, fixing...

if err != nil {
return nil, err
}

Expand Down