add ParseSrc function so the source of the datadict doesn't have to be a filepath. #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbusbey
reviewed
Feb 10, 2021
| if err := decoder.Decode(doc); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| b := new(builder) | ||
| var dict *DataDictionary | ||
| if dict, err = b.build(doc); err != nil { | ||
| dict, err := b.build(doc) |
There was a problem hiding this comment.
with this change, the declaration of dict above is no longer necessary
There was a problem hiding this comment.
ye, I thought it was there for stylistic reasons, fixing...
rubensayshi
force-pushed
the
datadict-from-src
branch
from
ef53302 to
388ef58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of having to provide a path it would be nice if we could provide the src ourselves, as this allows embedding the src into the binary, for example with
go:embedadded in go 1.16 :)this seems to be the simplest way of making this possible without having to expose the
builderand allows anyone to provide the source of the datadict in any way they like as a simplebytes.NewBuffer([]byte{})or with anything else that provides aio.Reader!