Skip some warning test on 3.10 to avoid MKL-related warning (and failure) #7373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
Mar 1, 2023
| if img_png.ndim != 3 or img_png.numel() < 100: | ||
| raise RuntimeError(f"Unexpected shape of img_png: {img_png.shape}") | ||
|
|
||
|
|
Member
Author
There was a problem hiding this comment.
these are drive-bys from pre-commit
8 tasks
pmeier
approved these changes
Mar 1, 2023
| if img_png.ndim != 3 or img_png.numel() < 100: | ||
| raise RuntimeError(f"Unexpected shape of img_png: {img_png.shape}") | ||
|
|
||
|
|
malfet
approved these changes
Mar 1, 2023
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
LGTM. By the way, did some digging: somehow those failures are triggered by pytest environment: running the same script outside of pytest did not result in the failure.
Contributor
|
It seems the issue is gone after #7189: https://github.com/pytorch/vision/actions/runs/4308089284/jobs/7513938565#step:10:2643 I'll send a separate PR for the lint fixes. But otherwise, we can probably close this one? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @malfet @atalman following up on our offline conversation, feel free to merge this PR or to submit a quick fix by pinning the numpy version as discussed.