Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Feb 27, 2023

Add smoke test based on: pytorch/builder#1318

Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atalman. A few minor suggestions inline

Comment on lines 34 to 35
out = model(x)
print(out.shape)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest will swallow all outputs unless the test is failing. Can we maybe assert the expected shape?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeier We basically want to see if compile works in this PR. As per: pytorch/builder#1318
Will do more testing of this and perhaps add assert as you suggest in the next PR.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock but @pmeier comments seem relevant

@atalman atalman merged commit 0e45022 into pytorch:main Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Hey @atalman!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug
Copy link
Member

@atalman should we cherry-pick that into the release branch immediately, or do we need to made for a new RC to be cut first?

@atalman
Copy link
Contributor Author

atalman commented Mar 1, 2023

@NicolasHug no not necessary for cherry pick since we are running tests from main.

facebook-github-bot pushed a commit that referenced this pull request Mar 30, 2023
Reviewed By: vmoens

Differential Revision: D44416574

fbshipit-source-id: 56a43636a40751a588aef96f22346304f6f29995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants