Let ufmt check run without pre-commit #5454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 6c41e4b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Member
|
I wonder if we should still keep the lint workflow failing until they fix it on ufmt's side, rather than risk merging un-formatted PRs? |
Member
|
Or, if this is a |
NicolasHug
changed the title
facebook-github-bot
pushed a commit
to meta-pytorch/data
that referenced
this pull request
Feb 22, 2022
Summary: Copycat of pytorch/vision#5454 Pull Request resolved: #241 Reviewed By: NivekT Differential Revision: D34399601 Pulled By: ejguan fbshipit-source-id: d1b5914542934b82ed0c7c8f77eba8682ae1ac5b
pmeier
added a commit
to pmeier/vision
that referenced
this pull request
Feb 23, 2022
This reverts commit 9301685.
datumbox
pushed a commit
that referenced
this pull request
Feb 23, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 25, 2022
Summary: * disable ufmt pre-commit hook * run ufmt outside of pre-commit Reviewed By: jdsgomes Differential Revision: D34475314 fbshipit-source-id: 8f35f71aadea65c2c09172ad39473d5f145fba98
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until omnilib/ufmt#56 is resolved, the
ufmthook cannot be installed and thus breaks the whole lint CI workflow (see for example https://app.circleci.com/pipelines/github/pytorch/vision/14964/workflows/2a6aab2b-9629-44ae-bf50-2b9c42dc85ca/jobs/1205317). Thus, we should disable it for now and wait until this is fixed upstream.