Skip to content

Reinstate ufmt pre commit hook #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2022
Merged

Reinstate ufmt pre commit hook #5460

merged 2 commits into from
Feb 23, 2022

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Feb 23, 2022 •
edited
Loading

Reverts #5454 since omnilib/ufmt#56 was fixed in ufmt==1.3.2.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 23, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0ec3acf (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI binary_linux_conda_py3.7_cu111 packaging/build_conda.sh 🔁 rerun

1 job timed out:

  • binary_linux_conda_py3.7_cu111
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pmeier pmeier marked this pull request as ready for review February 23, 2022 06:57
@pmeier pmeier requested a review from NicolasHug February 23, 2022 06:57
@pmeier pmeier added code quality dependency issue revert(ed) For reverted PRs, and PRs that revert other PRs labels Feb 23, 2022
datumbox
datumbox approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@datumbox datumbox merged commit c6b447b into pytorch:main Feb 23, 2022
@pmeier pmeier deleted the reinstate-ufmt-pre-commit branch February 23, 2022 08:33
facebook-github-bot pushed a commit that referenced this pull request Feb 25, 2022
@prabhat00155 @facebook-github-bot
[fbsync] Reinstate ufmt pre commit hook (#5460)
9b1d96d 
Summary:
* Revert "disable ufmt pre-commit hook (#5454)"

This reverts commit 9301685.

* upgrade ufmt to 1.3.2

Reviewed By: jdsgomes

Differential Revision: D34475325

fbshipit-source-id: 37297c4fe182c615af28a736bd41b6c4e8f774ab
@zhiqwang zhiqwang mentioned this pull request Mar 26, 2022
Closed
facebook-github-bot pushed a commit to meta-pytorch/torchrec that referenced this pull request Mar 29, 2022
@zhiqwang @facebook-github-bot
Reinstate ufmt pre commit hook (#180)
60f3036 
Summary:
Since omnilib/ufmt#56 is resolved, so I re-enable this hook, and upgrade it to v1.3.2 as pytorch/vision#5460 .

Pull Request resolved: #180

Reviewed By: colin2328

Differential Revision: D35197897

Pulled By: s4ayub

fbshipit-source-id: 5c024fbff1eddef523ef97bb95faca250ecb1ac4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed code quality module: ci revert(ed) For reverted PRs, and PRs that revert other PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pmeier @facebook-github-bot @datumbox @NicolasHug