[FBcode->GH] [PyTorch] Fix windows build for torchvision when MOBILE is defined (#4571)
#4742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytorch#4571) Summary: Pull Request resolved: pytorch#4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb
Contributor
💊 CI failures summary and remediationsAs of commit e8b92dc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pbelevich
approved these changes
Oct 26, 2021
seemethere
approved these changes
Oct 26, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
…ytorch#4571) (pytorch#4742) Summary: Pull Request resolved: pytorch#4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old FBcode=>GH commit which was missed.
Summary:
Pull Request resolved: #4571
Fixing windows build for
torchvisionwhenMOBILEis defined. Incsrc/vision.cpp, sincePyMODINIT_FUNCdepends onPython.hI added the same condition forPyMODINIT_FUNCas the one forimport <PyTorch.h>.Reviewed By: malfet
Differential Revision: D31488734
fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb