[PyTorch] Fix windows build for torchvision #4571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31488734 |
datumbox
reviewed
Oct 8, 2021
…ytorch#4571) Summary: Pull Request resolved: pytorch#4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: 88f24ccffbc3e05f0b7ecbb63dff16d41c8b5592
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D31488734 |
larryliu0820
force-pushed
the
export-D31488734-to-fbsync
branch
from
2cff471 to
e0df602
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
…4571) Summary: Pull Request resolved: #4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb
datumbox
reviewed
Oct 11, 2021
Contributor
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
LGTM. I'm not going to approve as we can't merge on fbsync branch. Feel free to merge on FBcode and we'll take care of the rest of the syncs.
| return NULL; | ||
| } | ||
| #endif | ||
| #endif // !defined(MOBILE) && defined(_WIN32) |
Contributor
There was a problem hiding this comment.
Just an optional nitpick. I checked the code-base and we typically do't mark endifs like this:
Suggested change
| #endif // !defined(MOBILE) && defined(_WIN32) | |
| #endif |
larryliu0820
changed the title
datumbox
pushed a commit
to datumbox/vision
that referenced
this pull request
Oct 26, 2021
…ytorch#4571) Summary: Pull Request resolved: pytorch#4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb
datumbox
added a commit
that referenced
this pull request
Oct 26, 2021
…4571) (#4742) Summary: Pull Request resolved: #4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb Co-authored-by: Mengwei Liu <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
…ytorch#4571) (pytorch#4742) Summary: Pull Request resolved: pytorch#4571 Fixing windows build for `torchvision` when `MOBILE` is defined. In `csrc/vision.cpp`, since `PyMODINIT_FUNC` depends on `Python.h` I added the same condition for `PyMODINIT_FUNC` as the one for `import <PyTorch.h>`. Reviewed By: malfet Differential Revision: D31488734 fbshipit-source-id: fd52a9ab161288d9c8bf3b9e0ab9da856a4ebadb Co-authored-by: Mengwei Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing windows build for
torchvision. Incsrc/vision.cpp, sincePyMODINIT_FUNCdepends onPython.hI added the same condition forPyMODINIT_FUNCas the one forimport <PyTorch.h>.Differential Revision: D31488734