Jpeg unpin - Cherrypicking #4288 #4344
Conversation
prabhat00155
left a comment
prabhat00155
left a comment
There was a problem hiding this comment.
Thanks @datumbox, a couple of minor comments.
| // For libjpeg version <= 9b, the out_size parameter in jpeg_mem_dest() is | ||
| // defined as unsigned long, where as in later version, it is defined as size_t. | ||
| // For windows backward compatibility, we define JpegSizeType as different types | ||
| // according to the libjpeg version used, in order to prevent compilcation |
| // according to the libjpeg version used, in order to prevent compilcation | ||
| // errors. | ||
| #if defined(_WIN32) || !defined(JPEG_LIB_VERSION_MAJOR) || \ | ||
| (JPEG_LIB_VERSION_MAJOR < 9) || \ |
There was a problem hiding this comment.
Why () around single condition?
|
Thanks for the quick review @prabhat00155. Definitely agree with your review comments. Note that this is a cherrypick from a different PR that landed on main branch that we try to bring on v0.10.1. Do you think it would be best to make this changes on a separate PR against main branch? |
Makes sense, I can do that, thanks! |
4 participants
Fixes #4181 on 0.10