-
Notifications
You must be signed in to change notification settings - Fork 814
Fix test execution in torchtext #1889
Fix test execution in torchtext #1889
Conversation
|
To confirm: Failures related to |
The plan is to investigate and resolve them in a followup PR. There aren't any significant changes in this PR that should cause that test to fail. |
joecummings
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mthrok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good.
-
test/.gitignore → test/torchtext_unittest/.gitignore: This file is empty. Do we need it?
-
Potential follow-up: keeping
assetdir and make integration test not access internals oftorchtext_unittestwould make it cleaner.
Was it failing before? |
Yes it was failing sporadically on certain python versions on Linux machines. Disabled them for the time being in #1901 |
Deleted the file
Added it as a followup item in PR description |
Description
test/torchtext_unittestdirectory and moves all the test scripts and assets there (this is in line with how torchaudio organizes it's unit tests)python setup.py developtopython setup.py installin CI jobcd test && pytest torchtext_unittest) so that repository root is not in Python module search path...common import ...) in test module to absolute import (from torchtext_unittest.common import ...)Additional context
Followups
test_vocab_from_raw_text_filefailure on linux platforms (Investigatetest_vocab_from_raw_text_filefailures on Linux #1900)torchtext_unittestCloses #1875