Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@pmabbo13 pmabbo13 requested a review from Nayef211 July 13, 2022 18:15
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmabbo13
Copy link
Contributor Author

Description

This module computes the relative position embeddings. This is the bias term that will be used when computing the attention scores. Our implementation is taken from HF.

@pmabbo13 pmabbo13 requested review from abhinavarora and parmeet July 15, 2022 15:57
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmabbo13 pmabbo13 merged commit 22f537b into gh/pmabbo13/11/base Jul 18, 2022
@facebook-github-bot facebook-github-bot deleted the gh/pmabbo13/11/head branch August 18, 2022 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants