This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 814
add t5 layer module that can be used for both encoder or decoder stack #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 12, 2022
…ecoder stack" [ghstack-poisoned]
This was referenced Jul 13, 2022
…ecoder stack" [ghstack-poisoned]
…ecoder stack" [ghstack-poisoned]
…ecoder stack" [ghstack-poisoned]
Nayef211
reviewed
Jul 13, 2022
Contributor
Nayef211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's highlight what the modifications are with the use of a PR comment
25 tasks
…ecoder stack" [ghstack-poisoned]
Contributor
Author
updated! |
Contributor
Author
DescriptionThe T5Layer implementation is very similar to the nn.TransformerEncoderLayer and nn.TransformerDecoderLayer implementations. The main differences are that:
|
parmeet
approved these changes
Jul 15, 2022
Contributor
parmeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
…ecoder stack" [ghstack-poisoned]
Nayef211
approved these changes
Jul 18, 2022
Contributor
Nayef211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ecoder stack" [ghstack-poisoned]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):