This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Automatically initialize submodule #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `git` submodule initialization commands at the beginning of setup, so that third party modules become available automatically. This makes it possible to install torchtext with a command like `pip install --no-use-pep517 git+https://github.com/pytorch/text.git` See also: - pytorch#1154 - pytorch/audio#1966
Nayef211
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Shall we close https://github.com/pytorch/text/pull/1154/files once this is merged?
yup. |
Thanks I wasn't aware of this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
gitsubmodule initialization commands at the beginningof setup, so that third party modules become available automatically.
This makes it possible to install torchtext with a command like
pip install --no-use-pep517 git+https://github.com/pytorch/text.gitexample
See also:
closes #1154