Fetch third party sources automatically #1966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
Nov 3, 2021
|
Hey @mthrok! |
mthrok
added a commit
that referenced
this pull request
Nov 3, 2021
After #1966, `git submodule` is performed automatically.
Merged
mthrok
added a commit
that referenced
this pull request
Nov 4, 2021
After #1966, `git submodule` is performed automatically.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Nov 30, 2021
This commit changes the build process so that the third party code are fetched automatically when `setup.py` is invoked. This is to allow 1. `build_sdist` to contain the third party library codes, so that source code distribution created at the time release tag is created is complete. 2. It makes it possible to do `pip install https://github.com/pytorch/audio.git`. Example: ``` !pip install 'cmake>=3.18' ninja !pip install --verbose git+https://github.com/pytorch/audio.git@auto-source ```
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Dec 3, 2021
This commit changes the build process so that the third party code are fetched automatically when `setup.py` is invoked. This is to allow 1. `build_sdist` to contain the third party library codes, so that source code distribution created at the time release tag is created is complete. 2. It makes it possible to do `pip install https://github.com/pytorch/audio.git`. Example: ``` !pip install 'cmake>=3.18' ninja !pip install --verbose git+https://github.com/pytorch/audio.git@auto-source ```
mthrok
added a commit
that referenced
this pull request
Dec 3, 2021
This commit changes the build process so that the third party code are fetched automatically when `setup.py` is invoked. This is to allow 1. `build_sdist` to contain the third party library codes, so that source code distribution created at the time release tag is created is complete. 2. It makes it possible to do `pip install https://github.com/pytorch/audio.git`. Example: ``` !pip install 'cmake>=3.18' ninja !pip install --verbose git+https://github.com/pytorch/audio.git@auto-source ```
mthrok
added a commit
to mthrok/text
that referenced
this pull request
Jun 23, 2022
This commit adds `git` submodule initialization commands at the beginning of setup, so that third party modules become available automatically. This makes it possible to install torchtext with a command like `pip install --no-use-pep517 git+https://github.com/pytorch/text.git` See also: - pytorch#1154 - pytorch/audio#1966
mthrok
added a commit
to pytorch/text
that referenced
this pull request
Jun 23, 2022
* Automatically initialize submodule This commit adds `git` submodule initialization commands at the beginning of setup, so that third party modules become available automatically. This makes it possible to install torchtext with a command like `pip install --no-use-pep517 git+https://github.com/pytorch/text.git` See also: - #1154 - pytorch/audio#1966
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
As system has been migrated to Focal few month back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the build process so that the third party code are fetched automatically when
setup.pyis invoked.This is to allow
build_sdistto contain the third party library codes, so that source code distribution created at the time release tag is created is complete.pip install https://github.com/pytorch/audio.git.Example: https://colab.research.google.com/drive/1hK-WfiIKDTgccOmbdPwMd-b9LTA8Yg0n?usp=sharing
Note:I am changing all the CI test job to usepip install ...in place ofpython setup.py ..., following the movement around PEP 517 (interesting read https://bernat.tech/posts/pep-517-518/), but I leave the packaging script as-is.See also pytorch/text#1154