Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Nayef211
Copy link
Contributor

Reference Issue: #1493

Description

  • Parameterize Amazon dataset tests
  • Deleted YelpReviewFull test since it's already parameterized
  • Renamed Squad test for consistency

Testing

  • pytest -s test_amazonreviews.py
  • pytest -s test_squads.py

Copy link
Contributor

@vcm2114 vcm2114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The standardization of the mock unit tests is nice!

@Nayef211 Nayef211 merged commit 08f49f9 into pytorch:main Feb 10, 2022
@Nayef211 Nayef211 deleted the test/parameterize_dataset_tests branch February 10, 2022 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants