Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Feb 4, 2022

Reference Issue: #1493

Summary

Added mocked unit test for IMDB dataset

Test

pytest test/datasets/test_imdb.py

@Nayef211 Nayef211 requested a review from parmeet February 8, 2022 16:15
@Nayef211 Nayef211 changed the title Add IMDB Mocked Unit Test #1578 Add IMDB Mocked Unit Test Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1579 (d2112ec) into main (da34de2) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   80.34%   81.08%   +0.73%     
==========================================
  Files          58       58              
  Lines        2569     2569              
==========================================
+ Hits         2064     2083      +19     
+ Misses        505      486      -19     
Impacted Files Coverage Δ
torchtext/datasets/imdb.py 97.36% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da34de2...d2112ec. Read the comment docs.

Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 31434ff into pytorch:main Feb 8, 2022
@Nayef211 Nayef211 deleted the test/mock_imdb branch February 8, 2022 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants