Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Convert get_mock_dataset fn in AmazonReviewPolarity to be private #1543

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Convert get_mock_dataset fn in AmazonReviewPolarity to be private #1543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
803f5cd
Convert _get_mock_dataset fn to be private
Jan 27, 2022
ef0df30
Merge branch 'main' into minor/rename_get_mock_dataset_fn
Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/datasets/test_amazonreviewpolarity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from ..common.torchtext_test_case import TorchtextTestCase


def get_mock_dataset(root_dir):
def _get_mock_dataset(root_dir):
"""
root_dir: directory to the mocked dataset
"""
Expand Down Expand Up @@ -54,7 +54,7 @@ class TestAmazonReviewPolarity(TempDirMixin, TorchtextTestCase):
def setUpClass(cls):
super().setUpClass()
cls.root_dir = cls.get_base_temp_dir()
cls.samples = get_mock_dataset(cls.root_dir)
cls.samples = _get_mock_dataset(cls.root_dir)

@parameterized.expand(["train", "test"])
def test_amazon_review_polarity(self, split):
Expand Down